Skip to content

doc: --config-opts single-item array wants second to be blank#1534

Merged
praiskup merged 1 commit intorpm-software-management:mainfrom
evan-goode:evan-goode/doc-array-config-opts
Feb 4, 2025
Merged

doc: --config-opts single-item array wants second to be blank#1534
praiskup merged 1 commit intorpm-software-management:mainfrom
evan-goode:evan-goode/doc-array-config-opts

Conversation

@evan-goode
Copy link
Member

When specifying an array with a single element using --config-opts, the user should specify the second item as empty, not the first:

Wrong:

$ mock --config-opts=foo= --config-opts=foo=bar --debug-config | grep foo
config_opts['foo'] = ['', 'bar']

Correct:

$ mock --config-opts=foo=bar --config-opts=foo= --debug-config | grep foo
config_opts['foo'] = ['bar']

The release notes where the feature was announced, Release-Notes-1.4.8.md, were correct but the man page was not.

I think this is probably label no-release-notes.

When specifying an array with a single element using --config-opts, the
user should specify the second item as empty, not the first:

Wrong:
$ mock --config-opts=foo= --config-opts=foo=bar --debug-config | grep foo
config_opts['foo'] = ['', 'bar']

Correct:
$ mock --config-opts=foo=bar --config-opts=foo= --debug-config | grep foo
config_opts['foo'] = ['bar']

The release notes where the feature was announced,
Release-Notes-1.4.8.md, were correct but the man page was not.
Copy link
Member

@xsuchy xsuchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@praiskup praiskup merged commit f7258cf into rpm-software-management:main Feb 4, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants