tox: drop python 3.8 from the list#1577
Merged
praiskup merged 1 commit intorpm-software-management:mainfrom May 6, 2025
Merged
tox: drop python 3.8 from the list#1577praiskup merged 1 commit intorpm-software-management:mainfrom
praiskup merged 1 commit intorpm-software-management:mainfrom
Conversation
praiskup
force-pushed
the
praiskup-no-python-3.8
branch
7 times, most recently
from
4e107f4 to
68bed7c
Compare
We still support Mock on RHEL 8, which runs on Python v3.6, and RHEL 9
which is on Python v3.9. Version 3.8 probably never used with Mock.
Currently tests fail with Python 3.8 (pyroute2 problem):
_____________ ERROR collecting mock/tests/test_package_manager.py ______________
mock/tests/test_package_manager.py:10: in <module>
from mockbuild.config import setup_default_config_opts
mock/py/mockbuild/config.py:29: in <module>
from .util import set_use_nspawn, setup_operations_timeout
mock/py/mockbuild/util.py:41: in <module>
from pyroute2 import IPRoute
.tox/py38/lib/python3.8/site-packages/pyroute2/__init__.py:16: in <module>
from pyroute2.cli.console import Console
.tox/py38/lib/python3.8/site-packages/pyroute2/cli/console.py:6: in <module>
from pyroute2.cli.session import Session
.tox/py38/lib/python3.8/site-packages/pyroute2/cli/session.py:9: in <module>
from pyroute2.cli.parser import Parser
.tox/py38/lib/python3.8/site-packages/pyroute2/cli/parser.py:13: in <module>
from pyroute2.common import basestring
.tox/py38/lib/python3.8/site-packages/pyroute2/common.py:90: in <module>
ns: dict[str, Any],
E TypeError: 'type' object is not subscriptable
praiskup
force-pushed
the
praiskup-no-python-3.8
branch
from
68bed7c to
cdc8712
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We still support Mock on RHEL 8+, which provides quite an old version of Python v3.9. But no need to worry about Python 3.8 which seems to fail in Tox now.