Remove traceLog decorator from pretty_getcwd#1584
Merged
xsuchy merged 1 commit intorpm-software-management:mainfrom May 27, 2025
Merged
Remove traceLog decorator from pretty_getcwd#1584xsuchy merged 1 commit intorpm-software-management:mainfrom
xsuchy merged 1 commit intorpm-software-management:mainfrom
Conversation
Member
|
I think removing the tracelog decorator will be simpler fix. We can live without it. |
Contributor
Author
|
@xsuchy That also works for me. I'll make that change to the PR. |
`pretty_getcwd()` is called during module import (to set `ORIGINAL_CWD`), and using a traced function creates unwanted side effects. Fixes: rpm-software-management#1583
ferdnyc
changed the title
praiskup
approved these changes
May 26, 2025
Member
|
the TF failure is not relevant to this PR. So merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pretty_getcwd()is called during module import (to setORIGINAL_CWD), and using a traced function creates unwanted side effects.Fixes: #1583
I think this can be
label no-release-notes, let me know if you disagree.