Skip to content

Podman save using id. #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matejonnet wants to merge 1 commit into from
+1 −1
Closed

Podman save using id. #1642

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mock/py/mock-hermetic-repo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ def prepare_image(image_specification, bootstrap_data, outputdir):
subprocess.check_output(pull_cmd)
subprocess.check_output(["podman", "save", "--format=oci-archive", "--quiet",
"-o", os.path.join(outputdir, "bootstrap.tar"),
image_specification])
bootstrap_data["id"]])
Copy link
Member

@praiskup praiskup Oct 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch!

It's strange this is needed only with the UBI 9 image, but not with Fedora. That said, are we doing something wrong with podman save, or the subsequent podman pull oci-archive:..? Is this a buggy OCI image? Would you mind reporting this against the Podman project?

If this patch works, it works, and the change seems safe. However, is it possible that podman pull could download an image with a different bootstrap_data["id"] (e.g., due to a race condition or a long delay between generating the lock file and downloading), leading to a subsequent podman save failure (or even worse, different (cached) image being stored)?



def _main():
Expand Down
Loading