unbreq plugin: unify output format#1664
Merged
praiskup merged 1 commit intorpm-software-management:mainfrom Dec 8, 2025
Merged
unbreq plugin: unify output format#1664praiskup merged 1 commit intorpm-software-management:mainfrom
praiskup merged 1 commit intorpm-software-management:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the logging output for the unbreq plugin to be more consistent by logging one event per BuildRequires field. The changes are clear and effectively achieve this goal. I have added a couple of suggestions to use f-strings for the new log messages to align with the prevailing style in the codebase, which should also improve readability.
Comment on lines
+241
to
242
| "unbreq plugin: BuildRequires '%s' is needed because file %s was accessed", | ||
| br, short_path |
There was a problem hiding this comment.
For consistency with the rest of the codebase, which already uses f-strings, consider converting this log message to use an f-string. This improves readability by embedding expressions directly inside the string literal.
Suggested change
| "unbreq plugin: BuildRequires '%s' is needed because file %s was accessed", | |
| br, short_path | |
| f"unbreq plugin: BuildRequires '{br}' is needed " | |
| f"because file {short_path} was accessed" |
praiskup
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
label no-release-notesLet's use one log event per one
BuildRequiresfield consistently.