Skip to content

unbreq plugin: unify output format#1664

Merged
praiskup merged 1 commit intorpm-software-management:mainfrom
mkoncek:unbreq
Dec 8, 2025
Merged

unbreq plugin: unify output format#1664
praiskup merged 1 commit intorpm-software-management:mainfrom
mkoncek:unbreq

Conversation

@mkoncek
Copy link
Contributor

@mkoncek mkoncek commented Dec 5, 2025

label no-release-notes

Let's use one log event per one BuildRequires field consistently.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the logging output for the unbreq plugin to be more consistent by logging one event per BuildRequires field. The changes are clear and effectively achieve this goal. I have added a couple of suggestions to use f-strings for the new log messages to align with the prevailing style in the codebase, which should also improve readability.

Comment on lines +241 to 242
"unbreq plugin: BuildRequires '%s' is needed because file %s was accessed",
br, short_path

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with the rest of the codebase, which already uses f-strings, consider converting this log message to use an f-string. This improves readability by embedding expressions directly inside the string literal.

Suggested change
"unbreq plugin: BuildRequires '%s' is needed because file %s was accessed",
br, short_path
f"unbreq plugin: BuildRequires '{br}' is needed "
f"because file {short_path} was accessed"

@praiskup praiskup merged commit a889e55 into rpm-software-management:main Dec 8, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants