mock: simplify forcearch code#1668
Merged
praiskup merged 1 commit intorpm-software-management:mainfrom Dec 8, 2025
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request simplifies the forcearch implementation by removing the need for most explicit architecture mappings in the configuration. Instead, it dynamically constructs the QEMU binary path from the architecture name, falling back to this convention if a specific mapping isn't found. This is a solid improvement for maintainability and makes adding new architectures much easier.
My review focuses on two main points:
- The lack of tests for this significant logic change. I've added a comment in
mock/py/mock.pyabout this. - A minor clarification in the new release notes to avoid potential user confusion.
Overall, the change is good, but adding tests is crucial to ensure its correctness and prevent future regressions.
81e76f2 to
1337b5f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mock now automatically maps the target build architecture directly to the
appropriate QEMU user-static binary variant for
forcearchbuilds. Forexample,
fedora-43-riscv64is mapped to/usr/bin/qemu-riscv64-static(seethe architecture string matches). Mock config contributors no longer need to
modify Mock code to add support for new architectures (if these architecture
specifiers match).