docs: document pre_srpm_build and umount_root hooks#1714
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds documentation for the pre_srpm_build and umount_root plugin hooks. The changes are clear and maintain the alphabetical order of the hook list. I have one suggestion to improve the clarity of the umount_root documentation by providing more context about its execution order relative to other hooks.
| * remove_snapshot | ||
| * rollback_to | ||
| * scrub | ||
| * umount_root - The counterpart to mount_root; called to instruct the buildroot-managing plugin to unmount the buildroot. |
There was a problem hiding this comment.
For better clarity and consistency with other hook descriptions, consider adding more context about when umount_root is called. Mentioning its position relative to other hooks like postumount and postclean would be very helpful for plugin developers. Also, mount_root should be enclosed in backticks for consistency.
| * umount_root - The counterpart to mount_root; called to instruct the buildroot-managing plugin to unmount the buildroot. | |
| * umount_root - The counterpart to `mount_root`. Called during cleanup to instruct a buildroot-managing plugin to unmount the buildroot. It is called after `postumount` and before `postclean`. |
There was a problem hiding this comment.
It is not called after postumount.
praiskup
added
no-release-notes
no-ci-builds
praiskup
merged commit 90f552e
into
rpm-software-management:main
2 participants
No description provided.