[opensuse] BinariesCheck: fix logic for missing-call-to-setgroups-before-setuid#1462
Merged
FilippoBonazziSUSE merged 2 commits intorpm-software-management:opensusefrom Feb 19, 2026
Conversation
In commit a6cf2c9 logic was introduced to selectively only report a warning for this diagnostic. The way it is currently done does not make any sense, however, the severity of this diagnostic is higher if the binary is installed setuid. Thus switch the order around.
…tuid Since we corrected the logic of error vs. warning we also need to adjust the tests accordingly.
FilippoBonazziSUSE
approved these changes
Feb 19, 2026
FilippoBonazziSUSE
merged commit e9daf10
into
rpm-software-management:opensuse
11 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In commit a6cf2c9 logic was introduced to selectively only report a warning for this diagnostic. The way it is currently done does not make any sense, however, the severity of this diagnostic is higher if the binary is installed setuid. Thus switch the order around.