Use OpenCV's brute-force match with cross-check instead of KNN match with ratio check and symmetry check#479
Open
borongyuan wants to merge 1 commit intorpng:masterfrom
Open
Use OpenCV's brute-force match with cross-check instead of KNN match with ratio check and symmetry check#479borongyuan wants to merge 1 commit intorpng:masterfrom
borongyuan wants to merge 1 commit intorpng:masterfrom
Conversation
…with ratio check and symmetry check
goldbattle
reviewed
Nov 30, 2025
|
|
||
| // Our descriptor matcher | ||
| cv::Ptr<cv::DescriptorMatcher> matcher = cv::DescriptorMatcher::create("BruteForce-Hamming"); | ||
| cv::Ptr<cv::BFMatcher> matcher = cv::BFMatcher::create(cv::NORM_HAMMING, true); |
Member
There was a problem hiding this comment.
So this enables the cross check.
Member
|
Hi, this is backwards compatible with OpenCV 3 correct? Seems like this is a decent replacement will need to test on a few datasets though myself before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described in the doc of BFMatcher::create, this is alternative to the ratio test. It is the fastest of the several methods I tested and simplifies a lot of code.