Add a ROS 2 node for serial MSCKF processing of ROS 2 bags#538
Open
0xWILL225 wants to merge 1 commit intorpng:masterfrom
Open
Add a ROS 2 node for serial MSCKF processing of ROS 2 bags#5380xWILL225 wants to merge 1 commit intorpng:masterfrom
0xWILL225 wants to merge 1 commit intorpng:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds the node ov_msckf/src/ros2_serial_msckf.cpp in
ov_msckf, a ROS 2 equivalent to the existingros1_serial_msckf, for processing ROS 2 bags. ov_eval/src/pose_to_file_ros2.cpp is added as an equivalent to ov_eval/src/pose_to_file.cpp, migrated to ROS 2, which fulfills an existing TODO. Changes were made to ov_eval/src/utils/Recorder.h to make it compatible with both ROS 1 and 2.I've also added scripts equivalent to run_ros_eth.sh and run_ros_uzhfpv.sh that use the added ROS 2 launch files instead of the existing ROS 1 ones to process all datasets in the EuRoC MAV and UZH-FPV collections. The scripts utilize environment variables instead of hard-coded paths. The newly added launch file ov_msckf/launch/serial.launch.py supports debugging the node with gdb.
I have tested the changes in a ROS 2 Humble Ubuntu 22.04 docker environment and verified that it works as expected on the EuRoC MAV datasets.