Only attempt to acquire a lock if there are jobs to enqueue.#322
Open
coredumperror wants to merge 2 commits intorq:masterfrom
Open
Only attempt to acquire a lock if there are jobs to enqueue.#322coredumperror wants to merge 2 commits intorq:masterfrom
coredumperror wants to merge 2 commits intorq:masterfrom
Conversation
There's no reason to acquire the lock if we have nothing to do. This change is primarily useful to prevent the warning from being heavily spammed when multiple docker containers running redundant webservers all run a scheduler against the same queue. The warning will be printed only if one of the schedulers actually fails to enqueue a job due to another one having already acquired the lock.
Author
|
How do I make it perform the checks? I don't know why they got canceled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's no reason to acquire the lock if we have nothing to do.
This change is primarily useful to prevent the warning from being heavily spammed when multiple docker containers running redundant webservers all run a scheduler against the same queue. The warning will be printed only if one of the schedulers actually fails to enqueue a job due to another one having already acquired the lock, rather than being spammed every single time the scheduler checks to see if it has any jobs to enqueue.