fix: add default_utc=True to cron.next()#324
Open
nicolapace wants to merge 1 commit intorq:masterfrom
Open
Conversation
I would assume end users would expect their Cron expressions to be evaluated against the system's timezone instead. Considering that, would |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix crontab FutureWarning for UTC behavior change
Update crontab usage to explicitly specify UTC behavior to resolve deprecation warnings and ensure consistent timezone handling.
What changed:
Added
default_utc=Trueparameter tocron.next()calls in rq_scheduler usageThis explicitly opts into the new UTC-aware behavior that will become default in crontab 0.22.0+
Why:
crontab library is changing default behavior from local time to UTC in version 0.22.0+
Current usage generates FutureWarning about this breaking change
Explicitly specifying
default_utc=Trueensures consistent UTC behavior across versionsAligns with best practices for scheduler operations which should use UTC
Testing:
Verified scheduled jobs continue to execute at correct times
Confirmed no regression in cron scheduling functionality
UTC timing behavior remains consistent
Note:
This change explicitly adopts the new UTC-first behavior that crontab will make default, ensuring our scheduler operations remain predictable across library updates.