Skip to content

Attempt to fix publishing in VS #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jmezach merged 7 commits into from
Feb 2, 2026
Merged

Attempt to fix publishing in VS #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
19873de
Attempt to fix publishing in VS
jmezach Jan 22, 2026
b57ff33
Consistency
jmezach Jan 22, 2026
ec001d5
Another attempt to fix VS publishing
jmezach Jan 23, 2026
6340963
Fix publishing in VS
jmezach Jan 27, 2026
f77fd97
Properly fix it now
jmezach Jan 27, 2026
89de0d8
Migrate to SLNX
jmezach Jan 27, 2026
e4325b5
Update src/MSBuild.Sdk.SqlProj/Sdk/Sdk.targets
jmezach Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 0 additions & 81 deletions MSBuild.Sdk.SqlProj.sln
View file
Open in desktop

This file was deleted.

22 changes: 22 additions & 0 deletions MSBuild.Sdk.SqlProj.slnx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
<Solution>
<Configurations>
<Platform Name="Any CPU" />
<Platform Name="x64" />
<Platform Name="x86" />
</Configurations>
<Folder Name="/Solution Items/">
<File Path=".editorconfig" />
<File Path=".github/workflows/main.yml" />
<File Path="Directory.Build.props" />
<File Path="README.md" />
<File Path="version.json" />
</Folder>
<Folder Name="/src/">
<Project Path="src/DacpacTool/DacpacTool.csproj" />
<Project Path="src/MSBuild.Sdk.SqlProj/MSBuild.Sdk.SqlProj.csproj" />
</Folder>
<Folder Name="/test/">
<Project Path="test/DacpacTool.Tests/DacpacTool.Tests.csproj" />
<Project Path="test/TestProject/TestProject.csproj" />
</Folder>
</Solution>
7 changes: 7 additions & 0 deletions src/MSBuild.Sdk.SqlProj/Sdk/Sdk.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@
PostBuildEvent
</CoreBuildDependsOn>
<GenerateNuspecDependsOn>$(GenerateNuspecDependsOn);SetNuSpecProperties</GenerateNuspecDependsOn>
<PublishDependsOn>_PublishBuildAlternative;_PublishNoBuildAlternative</PublishDependsOn>
<PublishDependsOn Condition="'$(BuildingInsideVisualStudio)' == 'true'">$(PublishDependsOn);PublishDatabase</PublishDependsOn>
<PublishContainerDependsOn>$(PublishContainerDependsOn);PrepareContainer</PublishContainerDependsOn>
</PropertyGroup>

Expand Down Expand Up @@ -267,6 +269,11 @@
<Delete Files="@(SqlArtifacts -> '$(TargetDir)%(Filename)%(Extension)')" />
</Target>

<!-- This target is run when using dotnet publish / Visual Studio publish. PublishDependsOn is set above to control what happens when using Publish in Visual Studio -->
<Target Name="Publish"
Condition="'$(IsPublishable)' == 'true'"
DependsOnTargets="$(PublishDependsOn)" />

<!-- Performs a publish of the .dacpac produced by build to a configurable target server -->
<!-- Note: This used to contain a condition that DeployOnPublish != False. Since you now have to explicitly run the PublishDatabase target this no longer made sense. -->
<Target Name="PublishDatabase" DependsOnTargets="Build">
Expand Down
Loading