Skip to content

Allow details tag in HTML5 #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Allow details tag in HTML5 #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions lib/html_sanitize_ex/scrubber/html5.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,35 @@ defmodule HtmlSanitizeEx.Scrubber.HTML5 do
"translate"
])

Meta.allow_tag_with_these_attributes("details", [
"accesskey",
"autocapitalize",
"autofocus",
"class",
"contenteditable",
"dir",
"draggable",
"hidden",
"id",
"inert",
"inputmode",
"is",
"itemid",
"itemprop",
"itemref",
"itemscope",
"itemtype",
"lang",
"name",
"open",
"slot",
"spellcheck",
"style",
"tabindex",
"title",
"translate"
])

Meta.allow_tag_with_these_attributes("div", [
"accesskey",
"class",
Expand Down
11 changes: 11 additions & 0 deletions test/html5_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,17 @@ defmodule HtmlSanitizeExScrubberHTML5Test do
assert input == full_html_sanitize(input)
end

test "does not strip details" do
input = """
<details name="foo" class="bar" open="open">
<summary>Details</summary>
Something small enough to escape casual notice.
</details>
"""

assert input == full_html_sanitize(input)
end

test "make sure a very long URI is truncated before capturing URI scheme" do
input =
"<img src='#{File.read!(Path.join(__DIR__, "html5_test_data_uri"))}'>"
Expand Down