Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/gorgeous-eels-rescue.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"rrweb": patch
---

Safer Media play/pause when target is not in fact a MediaElement
1 change: 1 addition & 0 deletions packages/rrweb/src/record/observer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1027,6 +1027,7 @@ function initMediaInteractionObserver({
const target = getEventTarget(event);
if (
!target ||
!(target instanceof HTMLMediaElement) ||
isBlocked(target as Node, blockClass, blockSelector, true)
) {
return;
Expand Down
18 changes: 16 additions & 2 deletions packages/rrweb/src/replay/media/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,14 @@ export class MediaManager {
this.mediaMap.forEach((_mediaState, target) => {
this.syncTargetWithState(target);
if (options.pause) {
target.pause();
try {
target.pause();
} catch (error) {
this.warn(
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/restrict-template-expressions
`Failed to sync media element: ${error.message || error}`,
);
}
}
});
}
Expand Down Expand Up @@ -104,7 +111,14 @@ export class MediaManager {

target.currentTime = seekToTime;
} else {
target.pause();
try {
target.pause();
} catch (error) {
this.warn(
// eslint-disable-next-line @typescript-eslint/no-unsafe-member-access, @typescript-eslint/restrict-template-expressions
`Failed to pause during seek: ${error.message || error}`,
);
}
target.currentTime = mediaState.currentTimeAtLastInteraction;
}
}
Expand Down
Loading