Fix timeout calculation to account for event duration and playback speed #1768
+17
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test timeout was hardcoded to 2 minutes regardless of event duration or playback speed, causing failures for longer recordings or slower playback.
Changes:
(max_timestamp - min_timestamp) / playback_speed + 120000msconfig.rrwebPlayer.speed(defaults to 1x)Example:
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.