Allow MachineID to be set#113
Merged
Conversation
Owner
|
What about using an env variable instead? |
Contributor
Author
|
I'd be down with that. If you have suggestions to what you'd want it to be, I can go ahead and make the changes. Maybe The nice part about having it as a function is that it allows code to be more explicit where needed. |
Owner
|
|
Contributor
Author
|
Updated. Also added a unit test. Let me know if that works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To go along with my suggestion in #112, this simple addition would solve some edge cases I've been seeing, and wouldn't change default behavior for generating ids.