Update chmo.Makefile to fix failing QC workflow#66
Merged
Conversation
StroemPhi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After upgrading to ODK v1.6, the QC workflow began failing because custom import module rules (obi, ms, chebi) listed mirror files as hard prerequisites. When
MIR=falsein the test pipeline, make would fail trying to satisfy these prerequisites before the rule body'sif [ $(IMP) = true ]guard could execute.Hence, this PR removes mirror files from the prerequisite line in the custom rules. They're still referenced inside the rule body when needed, but make no longer requires them to exist upfront. This allows the workflow to correctly skip import generation when
IMP=false.