Use io.Reader to avoid file size limits#26
Merged
rshade merged 5 commits intorshade:masterfrom Jul 11, 2024
Merged
Conversation
…hout reading its whole content on the server
mporsch
commented
Aug 16, 2023
| gopkg.in/inconshreveable/log15.v2 v2.0.0-20200109203555-b30bc20e4fd1 | ||
| ) | ||
|
|
||
| replace github.com/imdario/mergo => dario.cat/mergo latest |
Author
There was a problem hiding this comment.
This probably is not a proper solution, but I have to admit that I have no clue about go's dependency management.
Author
In any case the connection to that client is blocked up during the download and no parallel requests are possible. |
Owner
|
Hey @mporsch sorry I missed this, merging now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally created this PR in the source repo, but it seems it is not maintained anymore?
Maybe here I can get some more feedback.
=======
Currently the (download) file size is limited at 100MB.
If only this constant is increased, the server has to buffer all content in memory before passing it on.
In this PR we use an io.Reader to process everything as a stream.
Also we remove the file size limits and expose some timeouts to the command line timeout values of server and client.