CHAR should return nil for NULL values in column#2289
Open
sprileyMSTS wants to merge 1 commit intorsim:masterfrom
Open
CHAR should return nil for NULL values in column#2289sprileyMSTS wants to merge 1 commit intorsim:masterfrom
sprileyMSTS wants to merge 1 commit intorsim:masterfrom
Conversation
lib/active_record/connection_adapters/oracle_enhanced/oci_connection.rb - Return nil for NULL value in CHAR column similar to behavior in lib/active_record/connection_adapters/oracle_enhanced/jdbc_connection.rb
Author
|
Let me know if it's possible to backport this fix into a patch release of the 6.0 and 6.1 versions of this adapter. If not I'll have to release something internally at my company to address this issue until we can upgrade to Rails 7. |
Collaborator
|
Thanks for opening a pull request. Would you add some specs? |
|
Hi, any chance to get this into a release? We are upgrading a big application and having NULL in a CHAR column appearing as empty string instead of nil is giving us headaches as we have some CHAR columns with NOT NULL and there we expect empty strings indeed. So, casting empty strings in general to nil is not an option. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lib/active_record/connection_adapters/oracle_enhanced/oci_connection.rb
lib/active_record/connection_adapters/oracle_enhanced/jdbc_connection.rb