Enhance workaround for WeakMap with jruby >= 9.4.6.0#2360
Open
iaddict wants to merge 3 commits intorsim:masterfrom
Open
Enhance workaround for WeakMap with jruby >= 9.4.6.0#2360iaddict wants to merge 3 commits intorsim:masterfrom
iaddict wants to merge 3 commits intorsim:masterfrom
Conversation
Since jruby 9.4.6.0 the missing methods on ObjectSpace::WeakMap have been implemented. See: jruby/jruby#6683
…ound Enhance workaround for WeakMap with jruby >= 9.4.6.0
|
While pending on a new version, for the activerecord-oracle_enhanced-adapter 6.1.6 that we are currently using, we implemented a temporary workaround to rescue the NameError in begin
load File.expand_path("active_record/connection_adapters/oracle_enhanced_adapter.rb", $:.grep(/oracle_enhanced/).first)
rescue NameError => e
raise e unless e.message =~ /undefined field 'map'/
end |
Contributor
|
Another workaround to patch the gem each time after fresh install like in CI pipelines: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since jruby 9.4.6.0 the missing methods on ObjectSpace::WeakMap have been implemented.
See: jruby/jruby#6683
Without this fix the gem does not work on jruby 9.4.6.0.