Skip to content

perf: don't eval attr just pass to isinstance #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

perf: don't eval attr just pass to isinstance #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion django_lifecycle/mixins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ def _get_model_descriptor_names(cls) -> List[str]:
for name in dir(cls):
attr = getattr(cls, name, None)

if attr and isinstance(attr, DJANGO_RELATED_FIELD_DESCRIPTOR_CLASSES):
if isinstance(attr, DJANGO_RELATED_FIELD_DESCRIPTOR_CLASSES):
Copy link
Collaborator

@EnriqueSoria EnriqueSoria Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this avoid property evaluation? I'm not sure about it.

Could you make a test to prove it? If not I could help with that.

(sorry about answering so late)

descriptor_names.append(name)

return descriptor_names
Expand Down