Suppress libusb compile warnings#35
Open
stefan-sherwood wants to merge 1 commit intorsjudka:developfrom
Open
Conversation
Owner
|
this seems like more of a hack doesn't it? I think a cleaner way of fixing this would be done something like this: https://github.com/openDsh/aasdk/pull/2/files (just look specifically at the libusb stuff but you could always bring the other fixes in too) |
Author
|
I must be misunderstanding, It looks like the include isn't needed, in which case the library could also be removed. But if it is needed, it doesn't look like that fix would work. (I assumed it was being used) |
Owner
|
there is an include, it just moved to the |
Author
|
Ah, now I see it. The fix amounts to the same thing as mine. It suppresses warnings because it's labeled as a system include. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This same change can also be done for subprojects aasdk/ and openauto/ though I'm not sure the correct protocol for doing that.