Feature/fireblocks release by ronaldsg20 · Pull Request #1358 · rsksmart/2wp-app

ronaldsg20 · 2025-12-17T20:40:32Z

No description provided.

github-actions · 2025-12-17T20:42:29Z

Dependency Review

The following issues were found:

✅ 0 vulnerable package(s)
✅ 0 package(s) with incompatible licenses
✅ 0 package(s) with invalid SPDX license definitions
⚠️ 1 package(s) with unknown licenses.

View full job summary

Copilot

Pull request overview

This PR integrates Fireblocks wallet support into the PowPeg application, enabling users to perform peg-in transactions using Fireblocks vault accounts. The implementation includes a new setup flow for Fireblocks credentials (API key and private key file), JWT-based authentication, and a dedicated form for handling peg-in transactions without traditional wallet connections.

Key Changes:

Added Fireblocks wallet integration with credential management via IndexedDB
Implemented JWT authentication utilities for secure Fireblocks API communication
Created new UI components for Fireblocks setup and peg-in workflows

Reviewed changes

Copilot reviewed 21 out of 43 changed files in this pull request and generated 9 comments.

Show a summary per file

File	Description
vue.config.js	Added PWA configuration with icons and manifest settings
src/pegin/components/PegoutForm.vue	Added debug display for pegout quotes
src/pegin/views/SetUpIBI.vue	New dialog component for Fireblocks credential configuration
src/pegin/views/NoWalletPeginForm.vue	New form component for Fireblocks-based peg-in transactions
src/common/utils/jwtBuilder.ts	JWT builder utilities for Fireblocks API authentication
src/common/utils/txIdGenerator.ts	Transaction ID generation utility
src/common/utils/files.ts	File reading utility for credential handling
src/common/services/FireblocksService.ts	Service class for Fireblocks API interactions
src/common/composables/useIndexdedDB.ts	IndexedDB composable for persistent credential storage
src/common/types/Fireblocks.ts	TypeScript type definitions for Fireblocks entities
src/common/router/index.ts	Added routes for Fireblocks setup and peg-in flows
src/App.vue	Updated CSP and added storage persistence request
package.json	Added PWA plugin and Trezor type definitions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

src/common/router/index.ts

    },
  },
+  {
+    path: '/setupIBi',


Copilot · 2025-12-19T14:13:36Z

src/common/composables/useIndexedDB.ts

@@ -0,0 +1,78 @@
+export function useIndexedDB() {


Corrected spelling in filename from 'useIndexdedDB.ts' to 'useIndexedDB.ts'.

src/pegin/views/SetUpIBI.vue

+  computed, watch,
+} from 'vue';
+import { mdiArrowRight, mdiFileUpload, mdiKey } from '@mdi/js';
+import { useIndexedDB } from '@/common/composables/useIndexdedDB';


src/pegin/views/NoWalletPeginForm.vue

+import type { FireblocksTransactionParams, VaultAccount } from '@/common/types/Fireblocks';
+import { TransferPeerPathType } from '@/common/types/Fireblocks';
+import { appendRecaptcha, Machine, readFileAsText } from '@/common/utils';
+import { useIndexedDB } from '@/common/composables/useIndexdedDB';


src/App.vue

+      if (navigator.storage && navigator.storage.persist) {
+        navigator.storage.persist()
+          .then((persistent) => {
+            console.log(`Almacenamiento persistente: ${persistent}`);


src/pegin/views/NoWalletPeginForm.vue

+          txError.value = new ServiceError(
+            'FireblocksService',
+            'getVaultAccounts',
+            'The credential are invalid or expired, please check them and try again',


src/common/composables/useIndexdedDB.ts

@@ -0,0 +1,78 @@
+export function useIndexedDB() {
+  const dbName = 'my-db';


src/pegin/views/NoWalletPeginForm.vue

+        destination: {
+          type: TransferPeerPathType.OneTimeAddress,
+          subType: 'External',
+          name: 'LBC BTC Address',


sonarqubecloud · 2025-12-19T14:19:02Z

Quality Gate failed

Failed conditions
23.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Fixing types on transsaction request Fix Base url path on FireblocksService Add Fireblocks wallet button and NoWalletPegin form I've defined a new wallet button for fireblocks on pegin, it is connected to a new view to create a pegin tx with no wallet previously connected Finish Flyover flow using fireblocks on POC Remove home buttons and rename Fireblocks form buttons Remove native option Accepting quote and using lps destination address Check user privileges before enable the peginForm on fireblocks Fix error handling on the api user role Increase app version to 3.2 Remove IBI console Include JWT build function to create the fireblocks request on the UI I've defined the JWT creation method using the provede .key file and the defined methods in the FireblocksService in order to prevent sending credentials to the backend Update Fireblocks service to create the JWT on the ui Avoid use of Math.random in the txIdGenerator Include Vault selector for the Fireblock account

removing files and improve validations on form

Form validations for Fireblocks

sonarqubecloud · 2026-02-02T00:15:28Z

Quality Gate failed

Failed conditions
23.8% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

ronaldsg20 changed the base branch from feature/3.2 to security/3.2 December 17, 2025 20:40

ronaldsg20 force-pushed the feature/fireblocks-release branch 2 times, most recently from 40a16dd to d68435f Compare December 17, 2025 21:14

ronaldsg20 force-pushed the security/3.2 branch from 95dc363 to e0ecc90 Compare December 17, 2025 22:28

Base automatically changed from security/3.2 to feature/3.2 December 18, 2025 12:48

annipi force-pushed the feature/3.2 branch from 5931fdd to f772ee4 Compare December 18, 2025 19:08

Base automatically changed from feature/3.2 to main December 18, 2025 19:16

ronaldsg20 force-pushed the feature/fireblocks-release branch 2 times, most recently from ea789a1 to 42c9b8b Compare December 19, 2025 14:12

ronaldsg20 requested a review from Copilot December 19, 2025 14:12

Copilot AI reviewed Dec 19, 2025

View reviewed changes

ronaldsg20 force-pushed the feature/fireblocks-release branch from 42c9b8b to 6d35a3c Compare January 20, 2026 21:38

ronaldsg20 and others added 6 commits January 29, 2026 15:12

Enable Max button

5fa3966

Fix MaxValue for pegin tx calculation

3f6b335

Add estimation for gas on depositPegout method (Max button feature)

fb0be34

refactor: update reown from version 1.7.8 to 1.8.15

a9f2edf

Base PWA settings for IndexedDB use

9df5c6c

ronaldsg20 force-pushed the feature/fireblocks-release branch from 6d35a3c to c41cab2 Compare January 29, 2026 14:27

refactor(fireblocks-release): remove pwa features

b572cb6

removing files and improve validations on form

ronaldsg20 temporarily deployed to staging-testnet January 29, 2026 15:56 — with GitHub Actions Inactive

ronaldsg20 added 2 commits January 30, 2026 22:13

fix(Fireblocks form): Total amount to send

32569b7

fix(Form validation): Add validations

6bc98b1

Form validations for Fireblocks

ronaldsg20 temporarily deployed to staging-testnet January 30, 2026 22:21 — with GitHub Actions Inactive

refactor(fireblocks-form): use PeginQuote calculation

cbfafd3

ronaldsg20 temporarily deployed to staging-testnet February 2, 2026 00:14 — with GitHub Actions Inactive

ronaldsg20 temporarily deployed to staging-mainnet February 2, 2026 00:15 — with GitHub Actions Inactive

rsksmart deleted a comment from Copilot AI Feb 2, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/fireblocks release#1358

Feature/fireblocks release#1358
ronaldsg20 wants to merge 10 commits intomainfrom
feature/fireblocks-release

ronaldsg20 commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI Dec 19, 2025

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

sonarqubecloud bot commented Dec 19, 2025

Uh oh!

sonarqubecloud bot commented Feb 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,78 @@
		export function useIndexedDB() {
		const dbName = 'my-db';

Conversation

ronaldsg20 commented Dec 17, 2025

Uh oh!

github-actions bot commented Dec 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dependency Review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

This comment was marked as outdated.

Uh oh!

Copilot AI Dec 19, 2025

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

sonarqubecloud bot commented Dec 19, 2025

Quality Gate failed

Uh oh!

sonarqubecloud bot commented Feb 2, 2026

Quality Gate failed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Dec 17, 2025 •

edited

Loading