Skip to content

RSKIP551 - Disable RSKIP459#551

Merged
aeidelman merged 2 commits intomasterfrom
rskip551
Mar 24, 2026
Merged

RSKIP551 - Disable RSKIP459#551
aeidelman merged 2 commits intomasterfrom
rskip551

Conversation

@marcos-iov
Copy link
Contributor

No description provided.

Copilot AI review requested due to automatic review settings March 16, 2026 15:54
@github-actions
Copy link

github-actions bot commented Mar 16, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 48653c1.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new document RSKIP551.md intended to serve as an RSKIP template / starting point for RSKIP-551 within the IPs/ RSKIP repository.

Changes:

  • Introduces IPs/RSKIP551.md containing the standard RSKIP front matter and section scaffolding (Abstract/Motivation/Specification/Rationale/References).
  • Includes placeholder metadata fields and placeholder section text.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@marcos-iov marcos-iov changed the title Add RSKIP551 template RSKIP551 - Disable RSKIP459 Mar 24, 2026
@marcos-iov marcos-iov requested a review from Copilot March 24, 2026 14:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new RSKIP document (RSKIP-551) proposing to deprecate RSKIP-459 behavior around marking rejected/unrefundable peg-ins as processed, and registers the new RSKIP in the repository index.

Changes:

  • Add README index entry for RSKIP-551.
  • Add new proposal document IPs/RSKIP551.md describing the deprecation of RSKIP-459 semantics.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
README.md Adds RSKIP-551 to the RSKIP index table.
IPs/RSKIP551.md Introduces the new RSKIP-551 proposal text and metadata.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

| 540 |[Bridge method `getEstimatedFeesForNextPegOutEvent` improvements and new parameterized method](IPs/RSKIP540.md)| 04-DEC-2025 | MI | Usa | Core | 1 | Draft |
| 543 |[Implement EIP-2718 Typed Transactions in Rootstock](IPs/RSKIP543.md)| 05-JAN-2026 | PDG, SM | Sca, Usa | Core | 2 | Draft |
| 544 |[Reject new contract code starting with the `0xEF` byte](IPs/RSKIP544.md)| 05-JAN-2026 | PDG, SM | Usa | Core | 1 | Draft |
| 551 |[Deprecate RSKIP459](IPs/RSKIP551.md)| 18-MAR-26 | MI | Usa | Core | 1 | Draft |
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Created date format here ("18-MAR-26") is inconsistent with the other 2026 entries in this table (e.g., "05-JAN-2026"). Please switch to the 4-digit year format for consistency (e.g., "18-MAR-2026").

Suggested change
| 551 |[Deprecate RSKIP459](IPs/RSKIP551.md)| 18-MAR-26 | MI | Usa | Core | 1 | Draft |
| 551 |[Deprecate RSKIP459](IPs/RSKIP551.md)| 18-MAR-2026 | MI | Usa | Core | 1 | Draft |

Copilot uses AI. Check for mistakes.
Comment on lines +3 to +6
title: Deprecate RSKIP459
created: 18-MAR-26
author: MI
purpose: Usa
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The YAML front-matter created field uses a 2-digit year ("18-MAR-26"), but several recent RSKIPs use ISO format in front matter (e.g., created: 2026-01-05 in RSKIP543/544, created: 2025-10-10 in RSKIP536). Please align this to the current front-matter convention (ISO YYYY-MM-DD) to keep metadata machine-friendly.

Copilot uses AI. Check for mistakes.
Comment on lines +15 to +18
|**Title** |Deprecate RSKIP459 |
|**Created** |18-MAR-26 |
|**Author** |MI |
|**Purpose** |Usa |
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The **Created** date in the header table uses a 2-digit year ("18-MAR-26"). In other recent RSKIPs (e.g., RSKIP543/544) the table uses a 4-digit year ("05-JAN-2026"). Please update this to the 4-digit year format (e.g., "18-MAR-2026") to match the repository’s newer documents and the README index.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

@aeidelman aeidelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aeidelman aeidelman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aeidelman aeidelman merged commit 91cc88c into master Mar 24, 2026
8 checks passed
@aeidelman aeidelman deleted the rskip551 branch March 24, 2026 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants