Skip to content

Remove signatures from svp spend tx before searching it while running HSM #389

Closed
apancorb wants to merge 6 commits intolovell-700-rc-alphanetfrom
fix/remove-sigs
Closed

Remove signatures from svp spend tx before searching it while running HSM #389
apancorb wants to merge 6 commits intolovell-700-rc-alphanetfrom
fix/remove-sigs

Conversation

@apancorb
Copy link
Contributor

@apancorb apancorb commented Feb 5, 2025

Description

When running with an HSM, the node is unable to find the related event since it is taking account the hash of the transaction with the singnatures on it. It must remove the signatures from the bitcoin transaction before comparing with the tx hash of the event.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@github-actions
Copy link

github-actions bot commented Feb 5, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@apancorb apancorb changed the base branch from master to lovell-700-rc-alphanet February 5, 2025 15:35
@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 5, 2025

@apancorb apancorb closed this Feb 5, 2025
@apancorb apancorb deleted the fix/remove-sigs branch February 5, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants