Remove signatures from svp spend tx before searching it while running HSM #389
Closed
apancorb wants to merge 6 commits intolovell-700-rc-alphanetfrom
Closed
Remove signatures from svp spend tx before searching it while running HSM #389apancorb wants to merge 6 commits intolovell-700-rc-alphanetfrom
apancorb wants to merge 6 commits intolovell-700-rc-alphanetfrom
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
8029070 to
033d701
Compare
|
Update README with CodeQL badge
Bump version to 7.1.0.0
033d701 to
f7df772
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Description
When running with an HSM, the node is unable to find the related event since it is taking account the hash of the transaction with the singnatures on it. It must remove the signatures from the bitcoin transaction before comparing with the tx hash of the event.
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: