Refactor/dx 1614 optimize verification result table#251
Open
Refactor/dx 1614 optimize verification result table#251
Conversation
… table. Update sql schema. Update prisma schema.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
There was a problem hiding this comment.
Pull request overview
This PR extends the verification_result table and its Prisma model to store richer smart contract verification metadata (compiler/EVM settings, bytecodes/hashes, sources, etc.) and adds indexes to improve lookup performance on newly query-relevant fields.
Changes:
- Added multiple metadata columns to
verification_resultin both the SQL schema and Prisma model (contract details, compilation/optimization parameters, source/ABI-related data, bytecodes and hashes). - Added new indexes on
contract_name,deployment_bytecode_hash, andruntime_bytecode_hashto optimize common query patterns. - Updated the SQL schema version header and notes to V1.2.4 to document the new table shape and indexes.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
prisma/schema.prisma |
Expands the verification_result Prisma model with new mapped columns and adds corresponding Prisma indexes. |
prisma/rsk-explorer-database.sql |
Updates the canonical SQL schema (V1.2.4) to add the new columns and create the new indexes on verification_result. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the database schema and Prisma model for the
verification_resulttable to support more detailed contract verification metadata. The main changes include adding new columns for contract details, optimization settings, bytecode hashes, and other verification attributes, as well as introducing new indexes to improve query performance on these fields.Schema and model enhancements for contract verification:
verification_resulttable for contract name, verification date, optimization settings, compiler and EVM versions, source files, constructor arguments, deployment and runtime bytecodes and their hashes, libraries, method identifiers, remappings, IR usage, and language. [1] [2]Performance improvements:
contract_name,deployment_bytecode_hash, andruntime_bytecode_hashin theverification_resulttable to optimize queries involving these fields. [1] [2]Documentation update:
rsk-explorer-database.sqlto reflect the new version (V1.2.4) and summarize the added columns and indexes.