test: add dnhash/aclkey functional coverage #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Robot tests for dnhash and aclkey. Also fix dnhash exclusion precedence, trim aclkey keys correctly, and mask non-type flags in generic dataset queries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Robot functional tests for the fork-specific datasets:\n- dnhash: plain match + wildcard behavior\n- aclkey: refuse-by-default, pass with key, refuse unknown\n\nFixes uncovered by the new tests:\n- dnhash: plain exclusions now override wildcard matches (matches dnset semantics)\n- aclkey: do not include trailing whitespace in stored keys\n- generic: mask non-type flags in qi_tflag so aclkey's NSQUERY_KEY doesn't break qtype matching\n\nValidated locally: cmake build (-DNO_IPv6=ON), robot functional tests, python unit tests.