Update instructions for gems installations from git repository #2828
Conversation
README.md
Outdated
| if lib == 'rspec-rails' | ||
| gem lib, git: "https://github.com/rspec/rspec-rails" | ||
| else | ||
| gem lib, git: "https://github.com/rspec/rspec", glob: "#{lib}/#{lib}.gemspec" |
There was a problem hiding this comment.
Above it says that it requires "main" branch, but I believe this is the case with this notation as well.
It also corresponds to how we do it here ourselves
There was a problem hiding this comment.
To be honest this is out of date, you don't need to run against the main branch of the other libraries to run rspec-rails from git.
There was a problem hiding this comment.
Fair enough. And we don't have to run our rspec-rails CI against them, too, right?
There was a problem hiding this comment.
We do need git main on CI, but only on CI.
@rubysamurai Would you be up to simplify this section of the README?
There was a problem hiding this comment.
@pirj I just did. Thanks for the review!
|
Thanks, merged despite build failure because I fixed that elsewhere and this is only readme |
3 participants
Use RSpec monorepo for all related RSpec libraries.