Fix rails stats not finding spec directories when run outside app root #2879
+35
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
If you rebase |
tangposmarvin
force-pushed
the
fix-rails-stats-cwd
branch
from
c732ca0 to
5379b37
Compare
tangposmarvin
force-pushed
the
fix-rails-stats-cwd
branch
from
5379b37 to
3d5fb0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2862
The code statistics registration in the Railtie class body uses
Dir['./spec/**/*_spec.rb']which resolves relative toDir.pwd. Whenbin/rails statsis run from a directory other than the app root, no spec files are found and the output showsTest LOC: 0.This moves the registration into an initializer and uses
Rails.root.join(...)for absolute path resolution.