Add gcc info #22
Merged
Add gcc info #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While our "Core Lib" actually expects a GCC_TOOL (path) to be available, invoking the gcc_version() automatically cached the property into CMake's global scope. This fixes the issue.
Function obtains path to available GCC cli, and also assigns the obtained version. The gcc_version() util has been changed to use this new util to obtain GCC's version, which no longer bleeds variables into CMake's global scope.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR adds a new
gcc_info()util function that is able to obtain the path to GCC and the version. In addition, it also fixes the issue that an internal "GCC_TOOL" property was bleeding into CMake's global scope, due to auto-caching of variable by Cmake'sfind_program.