feat: save the feed URL on redirection #289
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcepl
force-pushed
the
286-save-URL-redirect
branch
from
9d8dc03 to
f2022cc
Compare
…test Add test/__init__.py and rename test/test.py to test/test_main.py. Signed-off-by: Matěj Cepl <[email protected]>
The `clean_result` method in `test/test.py` did not use any instance-specific data, so it has been refactored into a standalone function. This improves code clarity and modularity. The associated regular expressions have also been moved to the module level.
Updated test snapshots for 'tails' feeds due to changes in html2text output. Resolved ResourceWarning in rss2email/feeds.py doctest by ensuring file closure.
Automatically update a feed's URL when the server sends a redirect (a 301 or 308 status code) and --save-config option is set. There is a set of tests to confirm that the system correctly saves the new, redirected URL in the feed's settings. The tests verify that when a feed returns a 301 or 308 redirect status, the new URL is correctly updated in the feed's configuration and persisted. This finalises the implementation and ensures the feature works as intended. References: rss2email#286
mcepl
force-pushed
the
286-save-URL-redirect
branch
from
f2022cc to
04933ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatically update a feed's URL when the server sends a redirect (a 301 or 308 status code) and
--save-configoption is set.There is a set of tests to confirm that the system correctly saves the new, redirected URL in the feed's settings.
The tests verify that when a feed returns a 301 or 308 redirect status, the new URL is correctly updated in the feed's configuration and persisted. This finalises the implementation and ensures the feature works as intended.
References: #286