Skip to content

refactor(type): separate CompileTimeRetryOptions and RuntimeRetryOptions#13

Merged
SoonIter merged 1 commit intomainfrom
syt/format-the-rule-type
Jun 19, 2025
Merged

refactor(type): separate CompileTimeRetryOptions and RuntimeRetryOptions#13
SoonIter merged 1 commit intomainfrom
syt/format-the-rule-type

Conversation

@SoonIter
Copy link
Copy Markdown
Member

  1. separate CompileTimeRetryOptions and RuntimeRetryOptions

  2. make the playground work

  3. tsconfig.json more strict

Copilot AI review requested due to automatic review settings June 19, 2025 07:58
@SoonIter SoonIter enabled auto-merge (squash) June 19, 2025 07:59
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the retry options into separate compile-time and runtime types, updates the playground config to use the built distribution, and tightens the TypeScript configuration.

  • Splits PluginAssetsRetryOptions into RuntimeRetryOptions, CompileTimeRetryOptions, and re-combines them.
  • Introduces a dedicated AssetsRetryHookContext for delay hooks.
  • Updates the playground to import pluginAssetsRetry from the dist folder.

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.

File Description
src/types.ts Separated retry option types and added hook context type
playground/rsbuild.config.ts Switched plugin import to built dist output

@SoonIter SoonIter merged commit 21a5863 into main Jun 19, 2025
2 checks passed
@SoonIter SoonIter deleted the syt/format-the-rule-type branch June 19, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants