refactor(type): separate CompileTimeRetryOptions and RuntimeRetryOptions#13
Merged
refactor(type): separate CompileTimeRetryOptions and RuntimeRetryOptions#13
CompileTimeRetryOptions and RuntimeRetryOptions#13Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the retry options into separate compile-time and runtime types, updates the playground config to use the built distribution, and tightens the TypeScript configuration.
- Splits
PluginAssetsRetryOptionsintoRuntimeRetryOptions,CompileTimeRetryOptions, and re-combines them. - Introduces a dedicated
AssetsRetryHookContextfor delay hooks. - Updates the playground to import
pluginAssetsRetryfrom thedistfolder.
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/types.ts | Separated retry option types and added hook context type |
| playground/rsbuild.config.ts | Switched plugin import to built dist output |
chenjiahan
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
separate
CompileTimeRetryOptionsandRuntimeRetryOptionsmake the playground work
tsconfig.jsonmore strict