Skip to content

fix: remove unused string concatenation#30

Merged
chenjiahan merged 2 commits intomainfrom
syt/remove-unused-str
Aug 22, 2025
Merged

fix: remove unused string concatenation#30
chenjiahan merged 2 commits intomainfrom
syt/remove-unused-str

Conversation

@SoonIter
Copy link
Copy Markdown
Member

@SoonIter SoonIter commented Aug 22, 2025

image

Copilot AI review requested due to automatic review settings August 22, 2025 09:13
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes unused string generation logic from the createElement function in the initial chunk retry module. The function previously returned both an HTML element and a string representation, but only the element was being used.

  • Simplified the createElement function return type from { element: HTMLElement; str: string } | undefined to HTMLElement | undefined
  • Removed unused string attribute variables and string template generation code
  • Updated the reloadElementResource function to work with the simplified return type

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@SoonIter SoonIter requested a review from chenjiahan August 22, 2025 09:16
@chenjiahan chenjiahan changed the title chore: remove unused str fix: remove unused string concatenation Aug 22, 2025
Copy link
Copy Markdown
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chenjiahan chenjiahan merged commit c6f35fe into main Aug 22, 2025
2 checks passed
@chenjiahan chenjiahan deleted the syt/remove-unused-str branch August 22, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants