Skip to content

feat!: pure ESM package #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 2 commits into from
Apr 17, 2026
+31 −585
Merged

feat!: pure ESM package #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dc7fe5
feat!: pure ESM package
chenjiahan Apr 17, 2026
ea0b393
fix: dts
chenjiahan Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,9 @@
"exports": {
".": {
"types": "./dist/index.d.ts",
"import": "./dist/index.js",
"require": "./dist/index.cjs"
"default": "./dist/index.js"
Comment thread
chenjiahan marked this conversation as resolved.
}
Comment on lines 12 to 16
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Restore top-level "types" field for TS node resolution

Removing the root types field makes this package’s declarations undiscoverable for TypeScript projects that still use moduleResolution: "node" (or other non-NodeNext resolvers). With the current exports-only setup, those consumers now get TS2307 when importing rsbuild-plugin-rsc, even though dist/index.d.ts exists; this is a regression from the previous manifest and will break editor/type-checking in mixed or legacy configs until they migrate resolver settings.

Useful? React with 👍 / 👎.

},
"main": "./dist/index.cjs",
"types": "./dist/index.d.ts",
"files": [
"dist"
],
Expand All @@ -31,19 +28,17 @@
"devDependencies": {
"@playwright/test": "^1.59.1",
"@rsbuild/core": "^2.0.0-rc.2",
"@rslib/core": "^0.21.0",
"@rslint/core": "^0.4.2",
"@rslib/core": "0.21.0",
"@rstest/core": "^0.9.7",
"@types/fs-extra": "^11.0.4",
"@types/node": "^25.6.0",
"@types/react": "^19.2.14",
"@types/react-dom": "^19.2.3",
"@typescript/native-preview": "7.0.0-dev.20260412.1",
"fs-extra": "^11.3.4",
"playwright": "^1.59.1",
"prettier": "^3.8.2",
"prebundle": "1.6.4",
"react-server-dom-rspack": "0.0.2",
"rsbuild-plugin-arethetypeswrong": "^0.3.1"
"react-server-dom-rspack": "0.0.2"
},
"peerDependencies": {
"@rsbuild/core": "^2.0.0-0",
Expand Down
Loading
Loading