Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses type compatibility issues for the development server by updating type casts and field definitions.
- Updated the type cast in the super constructor of the RspackDevServer class in src/server.ts.
- Modified the proxy type in the dev server configuration in src/config.ts to use Required for better type safety.
Reviewed Changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/server.ts | Added a ts-ignore comment for rspack path types and updated the options cast in the constructor call. |
| src/config.ts | Changed the proxy field type from WebpackDevServer.ProxyConfigArray to Required<DevServer["proxy"]>. |
Files not reviewed (2)
- package.json: Language not supported
- pnpm-lock.yaml: Language not supported
GiveMe-A-Name
approved these changes
Apr 23, 2025
chenjiahan
approved these changes
Apr 23, 2025
9aoy
approved these changes
Apr 23, 2025
|
CI failed 😢 |
GiveMe-A-Name
approved these changes
Apr 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix dev server type to pass CI