Skip to content

Make card() a custom element #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Make card() a custom element #1009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
430537d
Make card() a custom element
cpsievert Mar 12, 2024
6834d75
`devtools::document()` (GitHub Actions)
cpsievert Mar 12, 2024
172a634
Resave data (GitHub Action)
cpsievert Mar 12, 2024
c7fa8c7
Wrap in custom element after appending attributes
cpsievert Mar 12, 2024
4fd2ec3
Wrap in custom element after appending attributes
cpsievert Mar 12, 2024
ac73851
`devtools::document()` (GitHub Actions)
cpsievert Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions R/card.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,18 +90,18 @@ card <- function(..., full_screen = FALSE, height = NULL, max_height = NULL, min
max_height = validateCssUnit(max_height),
min_height = validateCssUnit(min_height)
),
"data-bslib-card-init" = NA,
"data-full-screen" = if (full_screen) "false",
!!!attribs,
!!!children,
if (full_screen) full_screen_toggle(attribs$id),
card_init_js(),
component_dependencies()
)

tag <- bindFillRole(tag, container = TRUE, item = fill)
tag <- tagAppendAttributes(tag, class = class)

tag <- web_component("bslib-card", tag)

as_fragment(
tag_require(tag, version = 5, caller = "card()")
)
Expand Down Expand Up @@ -313,13 +313,6 @@ full_screen_toggle <- function(id_controls) {
)
}

card_init_js <- function() {
tags$script(
`data-bslib-card-init` = NA,
HTML("bslib.Card.initializeAllCards();")
)
}

full_screen_toggle_icon <- function() {
# https://www.visiwig.com/icons/
# https://www.visiwig.com/icons-license/
Expand Down
Binary file modified R/sysdata.rda
View file
Open in desktop
Binary file not shown.
330 changes: 0 additions & 330 deletions inst/components/dist/components.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions inst/components/dist/components.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading