Skip to content

feat: Add --bs-component-active-{bg,color} CSS variables #1050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
+20 −1
Draft

feat: Add --bs-component-active-{bg,color} CSS variables #1050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ce66002
feat: Add `--bs-component-active-{bg,color}` CSS variables
gadenbuie Apr 30, 2024
02490cf
Resave distributed files (GitHub Action)
gadenbuie Apr 30, 2024
fcf3309
Resave data (GitHub Action)
gadenbuie Apr 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified R/sysdata.rda
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion inst/css-precompiled/5/bootstrap.min.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 4 additions & 0 deletions inst/lib/bs5/scss/_root.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,6 +126,10 @@
--#{$prefix}form-invalid-color: #{$form-invalid-color};
--#{$prefix}form-invalid-border-color: #{$form-invalid-border-color};
// scss-docs-end root-form-validation-variables

// {bslib} additions
--#{$prefix}component-active-bg: #{$component-active-bg};
--#{$prefix}component-active-color: #{$component-active-color};
}

@if $enable-dark-mode {
Expand Down
15 changes: 15 additions & 0 deletions tools/patches/034-bootstrap-component-active-css-vars.patch
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
diff --git a/inst/lib/bs5/scss/_root.scss b/inst/lib/bs5/scss/_root.scss
index ab720a38..56f26f0b 100644
--- a/inst/lib/bs5/scss/_root.scss
+++ b/inst/lib/bs5/scss/_root.scss
@@ -126,6 +126,10 @@
--#{$prefix}form-invalid-color: #{$form-invalid-color};
--#{$prefix}form-invalid-border-color: #{$form-invalid-border-color};
// scss-docs-end root-form-validation-variables
+
+ // {bslib} additions
+ --#{$prefix}component-active-bg: #{$component-active-bg};
+ --#{$prefix}component-active-color: #{$component-active-color};
}

@if $enable-dark-mode {