Update LaTeX spanner width logic to use the correct columns #2079
Merged
rich-iannone merged 7 commits intorstudio:masterfrom Nov 17, 2025
Merged
Update LaTeX spanner width logic to use the correct columns #2079rich-iannone merged 7 commits intorstudio:masterfrom
rich-iannone merged 7 commits intorstudio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing logic to calculate the spanner widths in latex uses indexing rather than matching on the column names, meaning that hidden columns and reordered columns caused the incorrect widths to be used
The code also had repeats for calculating the number of stub columns, so tidied this up
Fixes: #2016
Fixes: #1922
Checklist
testthatunit tests totests/testthatfor any new functionality.