Skip to content

Conversation

@nealrichardson
Copy link
Contributor

Do it all at once so that every time we touch files in Positron we don't create extra diffs.

@nealrichardson
Copy link
Contributor Author

Both CI failures are expected. #884 fixes posit-connect; I filed #886 for the check-boards databricks issue.

@juliasilge
Copy link
Member

Can you tell me why the failure on the posit-connect action is expected?

@nealrichardson
Copy link
Contributor Author

Can you tell me why the failure on the posit-connect action is expected?

The action :::s a connectapi function that I deleted yesterday when removing the HackyConnect business in favor of the with-connect utility, the same one I put up a PR to add here (#884). I didn't realize it was being called anywhere outside of connectapi's own tests.

The existing workflow would probably pass if https://github.com/rstudio/pins-r/blob/main/.github/workflows/posit-connect.yaml#L30 were pinned to a particular release of connectapi or a github SHA before yesterday. But #884 also fixes it--the (new) posit-connect workflow is passing on that PR. I put this PR up now so that, assuming you wanted to air out the codebase anyway, we could merge this first and then I could rebase #884 so it only had the relevant changes. But it doesn't have to go in that order.

Copy link
Member

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for that info; I appreciate it! 🙌

Let's merge this, and then go back to #884.

@juliasilge juliasilge merged commit 7ab9286 into main Oct 29, 2025
13 of 15 checks passed
@nealrichardson nealrichardson deleted the air branch October 29, 2025 11:38
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants