Skip to content

Fixes Positron restart#1869

Merged
t-kalinowski merged 1 commit intomainfrom
fix/positron-restart
Dec 18, 2025
Merged

Fixes Positron restart#1869
t-kalinowski merged 1 commit intomainfrom
fix/positron-restart

Conversation

@dfalbel
Copy link
Member

@dfalbel dfalbel commented Dec 18, 2025

when reticulate restarts, reticulate initializes Python from within an
RPC method call (from ark) which in turn does not allow us to call into
getIpykernelPath (which happens when registering ark methods)

The solution here, is to store the ipykernel path when starting positron,
so we don't need to later call into the UI comm to get it.

when reticulate restarts, reticulate initializes Python from within an
RPC method call (from ark) which in turn does not allow us to call into
`getIpykernelPath` (which happens when registering ark methods)

The solution here, is to store the ipykernel path when starting positron,
so we don't need to later call into the UI comm to get it.
@dfalbel dfalbel requested a review from t-kalinowski December 18, 2025 15:17
@t-kalinowski
Copy link
Member

t-kalinowski commented Dec 18, 2025

Thanks Daniel!

Do you know if we have a positron:reticulate test that will fail if the return value of .getIpykernelPath() is changed upstream? (i.e., if the positron internals we're using move)?

@dfalbel
Copy link
Member Author

dfalbel commented Dec 18, 2025

Yes, I assume this will fail https://github.com/posit-dev/positron/blob/77f51685f2bb19b2493e03bbe5e5eb9aa89a22dc/test/e2e/tests/reticulate/reticulate-variables.test.ts#L15

if this changes. Unfortunately, most reticulate tests are disabled on Positron CI due to an issue with reticulate on linux.
I'm currently working on identifying that problem on linux. (see posit-dev/positron#10953)

@t-kalinowski t-kalinowski merged commit bc1b073 into main Dec 18, 2025
13 checks passed
@t-kalinowski t-kalinowski deleted the fix/positron-restart branch December 18, 2025 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants