Open
Conversation
Member
|
Thank you for the PR! This looks like the right fix to my eyes. Would you be able to add a snapshot/regression test that tests the happy path (no error), and also, captures the new error? Something like: test_that("....", {
local_edition(3)
expect_snapshot2(r_session({
library(reticulate)
py_require(....)
import("sys") # force python initialize
py_require(....) # happy path
py_require(....) # new error
})
)
}) |
Author
|
Thanks @t-kalinowski. Please take a look if this is what you had in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1872