Add support for setting resource profile in rstudioapi::launcherSubmitJob
#320
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for the resourceProfile parameter to the rstudioapi::launcherSubmitJob function. This enhancement allows users to specify a named resource profile for job submission that must be defined in the cluster configuration.
- Added
resourceProfileparameter tolauncherSubmitJobfunction with proper documentation - Implemented argument validation mechanism to ensure backward compatibility
- Updated documentation and roxygen version
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| R/launcher-functions.R | Added resourceProfile parameter to function signature and documentation |
| man/launcherSubmitJob.Rd | Updated documentation to include the new resourceProfile parameter |
| R/utils.R | Added checkApiArguments function for validating API arguments against RStudio versions |
| R/code.R | Integrated argument validation using the new checkApiArguments function |
| vignettes/r-session.Rmd | Minor title change |
| DESCRIPTION | Updated RoxygenNote version |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| #' | ||
| #' @param resourceProfile A resource profile name to be used for the job. The | ||
| #' resource profile must be defined in the cluster configuration. | ||
| #' |
There was a problem hiding this comment.
The documentation has trailing whitespace after the period on line 302. Remove the extra spaces for consistency with other parameter documentation.
| #' | |
| #' |
|
The checks are failing here because the definitions used here are ancient, I think -- let me see if I can update those. |
|
Do we need to fix the test-coverage check @kevinushey? Looks like it's waiting on a test runner that will never come... |
|
Let me see if I can figure out the best way to update there. |
Addresses #319.
@kevinushey let me know if there are any other reviewers we should include since we both contributed to the source changes!