-
Notifications
You must be signed in to change notification settings - Fork 36
Add support for setting resource profile in rstudioapi::launcherSubmitJob
#320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7cd20e5
Add support for setting resourceProfile in launcherSubmitJob
zachhannum 7f9035e
rebuild docs; silence warning
kevinushey 590a0c0
add helper for checking API arguments against what's available in RSt…
kevinushey 32fcaac
provide escape hatch
kevinushey 70189aa
re-generate R-CMD-check.yaml
kevinushey 2db61ea
update test coverage action
kevinushey File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,56 +1,62 @@ | ||
| # Workflow derived from https://github.com/r-lib/actions/tree/v2/examples | ||
| # Need help debugging build failures? Start at https://github.com/r-lib/actions#where-to-find-help | ||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - master | ||
| branches: [main, master] | ||
| pull_request: | ||
| branches: | ||
| - main | ||
| - master | ||
|
|
||
| name: test-coverage | ||
| name: test-coverage.yaml | ||
|
|
||
| permissions: read-all | ||
|
|
||
| jobs: | ||
| test-coverage: | ||
| runs-on: ubuntu-18.04 | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| RSPM: https://packagemanager.rstudio.com/cran/__linux__/bionic/latest | ||
| GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }} | ||
|
|
||
| steps: | ||
| - uses: actions/checkout@v2 | ||
|
|
||
| - uses: r-lib/actions/setup-r@v1 | ||
| id: install-r | ||
| - uses: actions/checkout@v4 | ||
|
|
||
| - name: Install pak and query dependencies | ||
| run: | | ||
| install.packages("pak", repos = "https://r-lib.github.io/p/pak/dev/") | ||
| saveRDS(pak::pkg_deps("local::.", dependencies = TRUE), ".github/r-depends.rds") | ||
| shell: Rscript {0} | ||
| - uses: r-lib/actions/setup-r@v2 | ||
| with: | ||
| use-public-rspm: true | ||
|
|
||
| - name: Restore R package cache | ||
| uses: actions/cache@v2 | ||
| - uses: r-lib/actions/setup-r-dependencies@v2 | ||
| with: | ||
| path: | | ||
| ${{ env.R_LIBS_USER }}/* | ||
| !${{ env.R_LIBS_USER }}/pak | ||
| key: ubuntu-18.04-${{ steps.install-r.outputs.installed-r-version }}-1-${{ hashFiles('.github/r-depends.rds') }} | ||
| restore-keys: ubuntu-18.04-${{ steps.install-r.outputs.installed-r-version }}-1- | ||
|
|
||
| - name: Install system dependencies | ||
| if: runner.os == 'Linux' | ||
| extra-packages: any::covr, any::xml2 | ||
| needs: coverage | ||
|
|
||
| - name: Test coverage | ||
| run: | | ||
| pak::local_system_requirements(execute = TRUE) | ||
| pak::pkg_system_requirements("covr", execute = TRUE) | ||
| cov <- covr::package_coverage( | ||
| quiet = FALSE, | ||
| clean = FALSE, | ||
| install_path = file.path(normalizePath(Sys.getenv("RUNNER_TEMP"), winslash = "/"), "package") | ||
| ) | ||
| print(cov) | ||
| covr::to_cobertura(cov) | ||
| shell: Rscript {0} | ||
|
|
||
| - name: Install dependencies | ||
| - uses: codecov/codecov-action@v5 | ||
| with: | ||
| # Fail if error if not on PR, or if on PR and token is given | ||
| fail_ci_if_error: ${{ github.event_name != 'pull_request' || secrets.CODECOV_TOKEN }} | ||
| files: ./cobertura.xml | ||
| plugins: noop | ||
| disable_search: true | ||
| token: ${{ secrets.CODECOV_TOKEN }} | ||
|
|
||
| - name: Show testthat output | ||
| if: always() | ||
| run: | | ||
| pak::local_install_dev_deps(upgrade = TRUE) | ||
| pak::pkg_install("covr") | ||
| shell: Rscript {0} | ||
| ## -------------------------------------------------------------------- | ||
| find '${{ runner.temp }}/package' -name 'testthat.Rout*' -exec cat '{}' \; || true | ||
| shell: bash | ||
|
|
||
| - name: Test coverage | ||
| run: covr::codecov() | ||
| shell: Rscript {0} | ||
| - name: Upload test results | ||
| if: failure() | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: coverage-test-failures | ||
| path: ${{ runner.temp }}/package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation has trailing whitespace after the period on line 302. Remove the extra spaces for consistency with other parameter documentation.