Fix sporadic dates (#3664)

NEWS.md

@@ -12,6 +12,8 @@
 
 * Fixed a bug with `sliderInput()` when used as a range slider that made it impossible to change the slider value when both handles were at the maximum value. (#4131)
 
+* `dateInput` and `dateRangeInput` will not send spurious values to the server while typing until the user presses enter or clicks out of the field (except for `null` or `NA` when the field is completely empty). (#3664)
+
 # shiny 1.9.1
 
 ## Bug fixes

inst/www/shared/shiny.js

@@ -8061,12 +8061,6 @@
     }, {
       key: "subscribe",
       value: function subscribe(el, callback) {
-        (0, import_jquery8.default)(el).on(
-          "keyup.dateInputBinding input.dateInputBinding",
-          function() {
-            callback(true);
-          }
-        );
         (0, import_jquery8.default)(el).on(
           "changeDate.dateInputBinding change.dateInputBinding",
           function() {
@@ -8510,12 +8504,6 @@
     }, {
       key: "subscribe",
       value: function subscribe(el, callback) {
-        (0, import_jquery9.default)(el).on(
-          "keyup.dateRangeInputBinding input.dateRangeInputBinding",
-          function() {
-            callback(true);
-          }
-        );
         (0, import_jquery9.default)(el).on(
           "changeDate.dateRangeInputBinding change.dateRangeInputBinding",
           function() {

srcts/src/bindings/input/date.ts

@@ -40,19 +40,15 @@ class DateInputBindingBase extends InputBinding {
     el;
   }
   subscribe(el: HTMLElement, callback: (x: boolean) => void): void {
-    $(el).on(
-      "keyup.dateInputBinding input.dateInputBinding",
-      // event: Event
-      function () {
-        // Use normal debouncing policy when typing
-        callback(true);
-      }
-    );
+    // Don't update when in the middle of typing; listening on keyup or input
+    // tends to send spurious values to the server, based on unpredictable
+    // browser-dependant interpretation of partially-typed date strings.
     $(el).on(
       "changeDate.dateInputBinding change.dateInputBinding",
       // event: Event
       function () {
         // Send immediately when clicked
+        // Or after typing, when enter pressed or focus lost
         callback(false);
       }
     );

srcts/src/bindings/input/daterange.ts

@@ -161,19 +161,15 @@ class DateRangeInputBinding extends DateInputBindingBase {
     this._setMax($endinput[0], $endinput.data("max-date"));
   }
   subscribe(el: HTMLElement, callback: (x: boolean) => void): void {
-    $(el).on(
-      "keyup.dateRangeInputBinding input.dateRangeInputBinding",
-      // event: Event
-      function () {
-        // Use normal debouncing policy when typing
-        callback(true);
-      }
-    );
+    // Don't update when in the middle of typing; listening on keyup or input
+    // tends to send spurious values to the server, based on unpredictable
+    // browser-dependant interpretation of partially-typed date strings.
     $(el).on(
       "changeDate.dateRangeInputBinding change.dateRangeInputBinding",
       // event: Event
       function () {
         // Send immediately when clicked
+        // Or after typing, when enter pressed or focus lost
         callback(false);
       }
     );