Skip to content

WIP feat: Allow for packages to be dynamically loaded in app #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

WIP feat: Allow for packages to be dynamically loaded in app #402

wants to merge 23 commits into from

Conversation

@schloerke
Copy link
Collaborator

@schloerke schloerke commented Feb 10, 2025 •
edited
Loading

The magic bits of this PR can be found at https://github.com/rstudio/shinytest2/pull/402/files#diff-1e9839b0ee9b578e1094ebabe21a38467f417789f5b3e17fec51556b6706a851R86-R95 where we use {pkgload} to load a local R package similar to how {testthat} will load a local R package when testing.

HOWEVER, the local R package will not be attached. The searchpaths() will be updated to include the local R package when accessed like a normal package. This is to mimic how Shiny will use the package when the app is run regularly. (Whereas when testing a local R package, it is fair to want the entire namespace to be available without a library() call.)

TODO:

  • Test local R package
  • Test golem app
  • Test rhino app

schloerke and others added 4 commits September 24, 2024 13:43
gadenbuie
gadenbuie reviewed Feb 10, 2025
View reviewed changes
schloerke and others added 17 commits February 10, 2025 16:58
@schloerke
Add pkgload as new dep
bf57461
@schloerke
Update test files
1fcf20a
@schloerke
Commit changes before chopping code
e89fdd2
@schloerke
Merge branch 'pkg_test_env' of https://github.com/rstudio/shinytest2 …
bbca165 
…into pkg_test_env
@schloerke
Do not enable the local package's namespace when testing
0d6bf0a
@schloerke
Remove old setup code
767f7ef
@schloerke
Be explicit on return value
eb95f71
@schloerke @gadenbuie
Update comment for load_package
67d8fd8 
Co-Authored-By: Garrick Aden-Buie <[email protected]>
@schloerke
Clean up loading code to only load exported source fns
b50d8d0
@schloerke
Move variant folders for more robust testing
13e5a58
@schloerke
Update to latest snaps
6c7fa51
@schloerke
Update local variable name used for testing
1a5fee0
@schloerke
Do not attach local package. Only add it to the search path for local…
db958d3 
… testing.
@schloerke
Update snaps
a1a8045
@schloerke
lint
58c7b59
@schloerke
Fix sanity check for testing (now that we're trying to compile the pa…
4feb531 
…ckage)
@schloerke
Add vanilla golem app to test
eea9330
This was referenced Feb 12, 2025
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gadenbuie gadenbuie gadenbuie left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@schloerke @gadenbuie