chore!: Skip all tests using AppDriver during CRAN testing. Deprecate cran= parameters#407
Merged
chore!: Skip all tests using AppDriver during CRAN testing. Deprecate cran= parameters#407
AppDriver during CRAN testing. Deprecate cran= parameters#407Conversation
schloerke
changed the title
AppDriver on CRAN. Deprecate cran= parametersAppDriver on CRAN. Deprecate cran= parameters
schloerke
changed the title
AppDriver on CRAN. Deprecate cran= parametersAppDriver during CRAN testing. Deprecate cran= parameters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the release notes to reflect a breaking change where any attempt to create an AppDriver during CRAN testing will trigger a call to testthat::skip_on_cran().
- Introduces a new "Breaking changes" section in NEWS.md.
- Documents the behavior change related to AppDriver and CRAN testing.
Files not reviewed (13)
- DESCRIPTION: Language not supported
- NAMESPACE: Language not supported
- R/app-driver-expect-download.R: Language not supported
- R/app-driver-expect-js.R: Language not supported
- R/app-driver-expect-screenshot.R: Language not supported
- R/app-driver-expect-values.R: Language not supported
- R/app-driver-initialize.R: Language not supported
- R/app-driver.R: Language not supported
- R/expect-snapshot.R: Language not supported
- man-roxygen/app-cran.R: Language not supported
- man-roxygen/variant.R: Language not supported
- man/AppDriver.Rd: Language not supported
- vignettes/use-package.Rmd: Language not supported
gadenbuie
reviewed
Mar 26, 2025
Member
gadenbuie
left a comment
gadenbuie
left a comment
There was a problem hiding this comment.
Let's do two additional things:
- Add a scary-looking environment variable that could be used to enable shinytest2 tests on CRAN
- Add this to the NEWS, along with link to shinytest2 article on package testing
schloerke
force-pushed
the
no_exec_on_cran
branch
from
86bb0dd to
7fb61ae
Compare
schloerke
force-pushed
the
no_exec_on_cran
branch
from
7fb61ae to
770f668
Compare
Co-authored-by: Garrick Aden-Buie <garrick@adenbuie.com>
schloerke
added a commit
that referenced
this pull request
Nov 18, 2025
* main: fix(snapshot): Use local testthat edition to announcing files (#419) feat: Allow for dev packages to be dynamically loaded (#402) fix(testthat): Use `muffle_expectation`, not `continue_test` (#418) v0.4.1 (#415) fix: default `transform=` to NULL, not itself (#413) Increment version number to 0.4.0.9000 v0.4.0 (#410) Pre-release cleanups for shinytest 2 0.3.3 (#409) feat: Add `transform=` parameter to `$expect_download()` and `$expect_values()` (#403) chore!: Skip all tests using `AppDriver` during CRAN testing. Deprecate `cran=` parameters (#407) docs: Namespace `ChromoteSession` (#406)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To address this, shinytest2 will also take the stance of never testing on CRAN as it requires chromote to work.
We will now call
testthat::skip_on_cran()if anAppDriveris attempted to be created during CRAN testing. To escape this behavior, set the system environment variableSHINYTEST2_APP_DRIVER_TEST_ON_CRAN=1.