Add test for hywiki-mode #839
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add test for hywiki-mode. Also remove the :toggle argument value.
Why
Adding more line coverage and noticed a problem while doing
that. Hence a small PR that only focus on the issue.
The :toggle parameter value does not do what you would
expect. define-minor-mode does the change of the minor-mode variable
but does not recognize :toggle.
Notes
Maybe using one minor mode for three states is not the best idea after
all. Toggling twice from :pages state active leads to :all state
active.
It seems define-minor-mode and define-global-minor-mode uses a pattern
that we could benefit from.
Lets look into this again.