Skip to content

Eliminate N+1 queries in scheduled tasks #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Eliminate N+1 queries in scheduled tasks #51

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
192a56f
Initial plan
Copilot Jan 13, 2026
4bd2046
Optimize database queries in scheduled tasks
Copilot Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion frappe_gmail_thread/tasks/daily.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,9 @@ def enable_pubsub_everyday():
return

gmail_accounts = frappe.get_all(
"Gmail Account", filters={"gmail_enabled": 1}, fields=["name"]
"Gmail Account",
filters={"gmail_enabled": 1, "refresh_token": ["is", "set"]},
fields=["name"],
)
for gmail_account in gmail_accounts:
gaccount = frappe.get_doc("Gmail Account", gmail_account.name)
Expand Down
7 changes: 3 additions & 4 deletions frappe_gmail_thread/tasks/sync.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,11 @@ def sync_emails():
gmail_accounts = frappe.get_all(
"Gmail Account",
filters={"gmail_enabled": 1},
fields=["name"],
fields=["name", "refresh_token", "linked_user"],
)
for gmail_account in gmail_accounts:
gaccount = frappe.get_doc("Gmail Account", gmail_account.name)
if gaccount.refresh_token:
user = gaccount.linked_user
if gmail_account.refresh_token:
user = gmail_account.linked_user
job_name = f"gmail_thread_sync_{user}"
if not is_job_enqueued(job_name):
frappe.enqueue(
Expand Down