Skip to content

fix: add null checks for frm.timeline in activity.js#55

Closed
trufurs wants to merge 3 commits intodevelopfrom
fix/form-bug
Closed

fix: add null checks for frm.timeline in activity.js#55
trufurs wants to merge 3 commits intodevelopfrom
fix/form-bug

Conversation

@trufurs
Copy link
Member

@trufurs trufurs commented Mar 9, 2026

Description

This PR fixes the form bug when the form is opened for a virtual doctype.

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast

Checklist

  • I have carefully reviewed the code before submitting it for review.
  • This code is adequately covered by unit tests to validate its functionality.
  • I have conducted thorough testing to ensure it functions as intended.
  • A member of the QA team has reviewed and tested this PR (To be checked by QA or code reviewer)

Fixes #55

@trufurs trufurs marked this pull request as ready for review March 10, 2026 04:13
@trufurs trufurs requested a review from niraj2477 March 10, 2026 07:13
@trufurs
Copy link
Member Author

trufurs commented Mar 12, 2026

@niraj2477 Moving to new PR which show no lint issues
#57

@trufurs trufurs closed this Mar 12, 2026
@trufurs trufurs deleted the fix/form-bug branch March 12, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants